Manual proportions visual fixes #1449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Added info icon that you can hover/click on mobile to get info tooltip. Explanation: now you wont get tooltip if your mouse hovered on the empty space in the middle of the block, which looked a bit random, especially without reaction of the body part name to the hover. Now you see tooltip only if you need info about that body part. - Opacity of the incrementation buttons was changed: you dont really need to have them that transparent when they out of hover, it is messing with a contrast and you need to hover on each of them if you want to comfortably read them. Now you don't need to hover them for that, but opacity changes on hover anyway to show subtly that block are hovered :3 - I change scale of the "more proportion" down arrow when you hover, i think its cool instead of when nothing happens. Also i didn't added an svg for that icon because i don't think i really need svg for an i and border around it :D
|
|
|
@loucass003 @ImUrX Should I fix something here? |
ImUrX
requested changes
Jun 1, 2025
gui/src/components/onboarding/pages/body-proportions/BodyProportions.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/body-proportions/BodyProportions.tsx
Outdated
Show resolved
Hide resolved
gui/src/components/onboarding/pages/body-proportions/BodyProportions.tsx
Outdated
Show resolved
Hide resolved
Made a little logic that allows to control button increment component bg
ImUrX
approved these changes
Jun 3, 2025
|
Changed the name of the boolean prop for the IncrementButton to bgDark, when its false its light |
loucass003
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Also, I didn't add an SVG for that icon because I don't think I need SVG for an I and border around it :D