-
-
Notifications
You must be signed in to change notification settings - Fork 322
Sfusion mag support #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gorbit99
wants to merge
43
commits into
SlimeVR:main
Choose a base branch
from
gorbit99:sfusion-mag-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Sfusion mag support #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a define, can you use the config boolean like in BNO? So it can be controlled from the server |
@Eirenliel That's indeed the idea down the line (as in before I make this PR be not a draft), but for devving, this was quicker |
Also needs support for the QMC that will be on the v1.2 slimes |
Move sensor building logic to a separate class and file Don't use templates for RegisterInterface/I2CImpl/SPIImpl This started getting ridiculous, now we can actually maintain it. Make BNO085 work again Add BNO to automatic detection, remove a bunch of others Not all IMU types are enabled right now due to code size optimization, but it could be expanded in the future with optimization of Softfusion. Pick IMU type automatically by asking it
Fix: ES32 -> ESP32
Add definitions for SlimeVR v1.2 Fix typo and add comments to quaternion sandwich function
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sensor AUX interface mag support to sfusion IMUs.
Currently the effort is put in for the following IMUs:
And the following magnetometers attached to them:
As these are the ones easily available/used in the wild, but the PR aims to make adding support for new IMUs or magnetometers fairly straightforward.