-
-
Notifications
You must be signed in to change notification settings - Fork 331
Flex Sensor Implementation #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gorbit99
wants to merge
12
commits into
main
Choose a base branch
from
ads111x-implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eirenliel
requested changes
Mar 21, 2025
Eirenliel
requested changes
Apr 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be rebased
Converting this to a draft, so I can implement parallel muxes first |
I'll update this after other PRs are merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the partial implementation of flex sensors into the firmware. This is done in 2 parts:
In addition to the above changes, it refactors some of the logic behind ADC reading to make it more modular and make supporting future ICs easier.
Caveats:
The max reading rate of the ADS1115 ic is 680 reads per second, which is shared among the connected flex sensors, and it makes the microcontroller busywait for 1/680 seconds each read. Due to this I lowered down the max output rate of flex sensors to 60Hz to mitigate this issue. It might be wise to implement this limitation in the ADS1115 implementation instead if it turns out that 60Hz isn't nearly enough for these.