Skip to content

Move state update check logic to the sensor class #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Move state update check logic to the sensor class #432

wants to merge 4 commits into from

Conversation

gorbit99
Copy link
Contributor

Completes #422

@gorbit99 gorbit99 requested a review from unlogisch04 April 28, 2025 17:51
@gorbit99 gorbit99 requested a review from Eirenliel as a code owner April 28, 2025 17:51
@unlogisch04
Copy link
Contributor

Technically complete.
I was also hoping to get ride of the following variables too.
m_AckedSensorState
m_AckedSensorCalibration
m_AckedSensorConfigData

unlogisch04
unlogisch04 reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@unlogisch04 unlogisch04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally what i was thinking of thanks.
The only open thing to approve is the test for that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlogisch04 unlogisch04 unlogisch04 approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gorbit99 @unlogisch04