Move SERVER_SEARCHING LED status indication to the LEDManager#439
Closed
SomaticTom wants to merge 0 commit intoSlimeVR:mainfrom
Closed
Move SERVER_SEARCHING LED status indication to the LEDManager#439SomaticTom wants to merge 0 commit intoSlimeVR:mainfrom
SomaticTom wants to merge 0 commit intoSlimeVR:mainfrom
Conversation
gorbit99
reviewed
May 6, 2025
Author
|
A possible fix for #275 |
Eirenliel
requested changes
May 14, 2025
Member
Eirenliel
left a comment
Eirenliel
left a comment
There was a problem hiding this comment.
There is no difference between server searching and server connecting statuses. In fact, server connecting was meant for this, it was just not used properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SERVER_SEARCHING status to the StatusManager and move the server searching LED effect to the LEDManager. This allows other LED status indications, like charging and charge complete to show if the tracker is connected to WiFi but the server is not running.