Run CI for new boards with own defines #443
Conversation
| #ifndef IMU | ||
| #define IMU IMU_AUTO | ||
| #endif | ||
| #ifndef SECOND_IMU | ||
| #define SECOND_IMU IMU_AUTO | ||
| #endif | ||
| #ifndef BOARD | ||
| #define BOARD BOARD_SLIMEVR_V1_2 | ||
| #endif | ||
| #ifndef IMU_ROTATION | ||
| #define IMU_ROTATION DEG_270 | ||
| #endif | ||
| #ifndef SECOND_IMU_ROTATION | ||
| #define SECOND_IMU_ROTATION DEG_270 | ||
| #endif | ||
|
|
||
| #ifndef PRIMARY_IMU_OPTIONAL | ||
| #define PRIMARY_IMU_OPTIONAL false |
There was a problem hiding this comment.
Don't think wrapping these in ifndefs is necessary. Where else would the user define these? Honestly would just leave them there and if someone were to want to change these they can in place.
There was a problem hiding this comment.
they are needed for the build.py because it will redefine the board.
I also think not the nicest solution.
[env:BOARD_SLIMEVR_V1_2]
platform = espressif8266 @ 4.2.1
board = esp12e
build_flags =
${env.build_flags}
-D BOARD=BOARD_SLIMEVR_V1_2Maybe nicer would be to have defines.h excluded if we run ci with -D NODEFINES=true ? And disable the include in globals.h?
So it would not affect the avarange diy person or webflasher.
There was a problem hiding this comment.
It will not affect webflasher anyway, because the guards aren't required unless the defines are set outside of the defines.h. Webflasher modifies the defines.h, so it should work okay. DIY ppl can just ignore them. I think it's a better solution than to repeat all defines in the build flags, that way anything new won't be needed to be added everywhere.
|
Maybe i am picky. But the massive if in the defines for all the gloves defines, i cannot even find the endif from github preview. Maybe we could put that whole thing into its own header? |
Makes CI run for new boards, but this time it also sets defines correctly, so the FW can be used in updates, and it also gets properly tested. It also builds glove fw for fun of it, and we can just set whatever defines we want to test in the matrix and it will do it.
I also "by accident" reorganized stuff a bit...