Fix sensor count reporting #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is a correct behavior. If there are ERRORS it still should be like sensor is attached. It should only be not a sensor if the sensor isn't found, which isn't what isWorking() checks. |
|
@Eirenliel this PR just restores the behaviour of the code from before code cleanup was merged. I think it is the correct behaviour, as a sensor shouldn't really be considered "configured" if it couldn't be communicated with. |
Eirenliel
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently main, when not using IMU_AUTO, will report the configured sensor count ("n sensor(s) configured") as the number of entries in the SENSOR_DESC_LIST, even if some of them fail to be configured. This PR fixes that.