Skip to content

WWSTCERT-6385 Yale Lock with Matter #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

greens
Copy link
Contributor

@greens greens commented May 30, 2025

No description provided.

Copy link

Copy link

github-actions bot commented May 30, 2025

Test Results

   67 files    440 suites   0s ⏱️
2 250 tests 2 250 ✅ 0 💤 0 ❌
3 841 runs  3 841 ✅ 0 💤 0 ❌

Results for commit ef72e66.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 30, 2025

File Coverage
All files 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ef72e66

@hcarter-775
Copy link
Contributor

we need to add the product info to this table in the new-matter-lock subdriver for it to function properly:

local NEW_MATTER_LOCK_PRODUCTS = {
  {0x115f, 0x2802}, -- AQARA, U200
  {0x115f, 0x2801}, -- AQARA, U300
  {0x147F, 0x0001}, -- U-tec
  {0x144F, 0x4002}, -- Yale, Linus Smart Lock L2
  {0x1533, 0x0001}, -- eufy, E31
  {0x1533, 0x0002}, -- eufy, E30
  {0x1533, 0x0003}, -- eufy, C34
  {0x1533, 0x000F}, -- eufy, FamiLock S3 Max
  {0x1533, 0x0010}, -- eufy, FamiLock S3
  {0x1533, 0x0011}, -- eufy, FamiLock E34
  {0x1533, 0x0012}, -- eufy, FamiLock E35
  {0x135D, 0x00B1}, -- Nuki, Smart Lock Pro
  {0x135D, 0x00B2}, -- Nuki, Smart Lock
  {0x135D, 0x00C1}, -- Nuki, Smart Lock
  {0x135D, 0x00A1}, -- Nuki, Smart Lock
  {0x135D, 0x00B0}, -- Nuki, Smart Lock
  {0x10E1, 0x2002}  -- VDA
}

@greens
Copy link
Contributor Author

greens commented May 30, 2025

@hcarter-775 thanks. Updated

@hcarter-775
Copy link
Contributor

hcarter-775 commented May 30, 2025

weird thing, apparently one of the manufacturer_info fields in the lock unit test suite uses this exact vendor id and product id. we should change those to anything else for the unit tests to pass:

local mock_device_record = {
  profile = t_utils.get_profile_definition("lock-without-codes.yml"),
  manufacturer_info = {vendor_id = 0x101D, product_id = 0x1},

@greens
Copy link
Contributor Author

greens commented May 30, 2025

@hcarter-775 and updated again

@tpmanley
Copy link
Contributor

I have some questions about this one that I'm brining up internally before we go ahead with the merge

Copy link
Contributor

@tpmanley tpmanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific changes requested right now, but just hold on merging this for now please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants