-
Notifications
You must be signed in to change notification settings - Fork 491
WWSTCERT-6385 Yale Lock with Matter #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Invitation URL: |
Test Results 67 files 440 suites 0s ⏱️ Results for commit ef72e66. ♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against ef72e66 |
we need to add the product info to this table in the
|
@hcarter-775 thanks. Updated |
weird thing, apparently one of the manufacturer_info fields in the lock unit test suite uses this exact vendor id and product id. we should change those to anything else for the unit tests to pass:
|
@hcarter-775 and updated again |
I have some questions about this one that I'm brining up internally before we go ahead with the merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No specific changes requested right now, but just hold on merging this for now please
No description provided.