Skip to content

Add Eve MotionBlinds to subdriver #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickolas-deboom
Copy link
Contributor

Add Eve vid and pid to subdriver to account for position updates while the shade is in motion.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Add Eve vid and pid to subdriver to account for position updates while
the shade is in motion.
Copy link

github-actions bot commented Jun 4, 2025

Copy link

github-actions bot commented Jun 4, 2025

Test Results

   67 files  ±0    440 suites  ±0   0s ⏱️ ±0s
2 250 tests ±0  2 250 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 841 runs  ±0  3 841 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a8c0180. ± Comparison against base commit 634161b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2025

File Coverage
All files 74%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/matter-window-covering-position-updates-while-moving/init.lua 36%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against a8c0180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant