Skip to content

Integrate the matter window covering subdriver into the main driver #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickolas-deboom
Copy link
Contributor

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

The subdriver existed to handle devices that send position updates while the shade is in motion. This PR integrates the functionality from the subdriver into the main driver in order to avoid having to maintain a subdriver.

Summary of Completed Tests

Needs testing on devices that send position updates while in motion as well as devices that do not.

The subdriver existed to handle devices that send position updates while
the shade is in motion. This PR integrates the functionality from the
subdriver into the main driver in order to avoid having to maintain a
subdriver.
@nickolas-deboom nickolas-deboom force-pushed the matter-window-covering-integrate-subdriver branch from dd1215c to 3ef9c95 Compare June 4, 2025 19:23
Copy link

github-actions bot commented Jun 4, 2025

Copy link

github-actions bot commented Jun 4, 2025

File Coverage
All files 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3ef9c95

Copy link

github-actions bot commented Jun 4, 2025

Test Results

   67 files  ±0    440 suites  ±0   0s ⏱️ ±0s
2 250 tests ±0  2 250 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 841 runs  ±0  3 841 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3ef9c95. ± Comparison against base commit 634161b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant