Rolling up main to beta #2226
Merged
Rolling up main to beta #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunsup Jung <[email protected]>
add zigbee-bed shus mattress device
Added binding requests for each endpoint.
Release of the driver to general population has revealed that there are
various crashes along pathological code paths for the Sonos driver.
These are pathological paths that didn't show up in testing, and based
on where the fixes were made, these would be devices that are already
non-functional in some capacity.
The paths have been adjusted to avoid crashing where possible, with
increased logging, including some logging to hub-core where the nature
of the crash (typically unexpected input) is something that hasn't been
seen or reproduced yet, so that we can hopefully get more info in the
future.
These are the fixes that have been made:
- Bad `string.format` call on pathological log line
- Additional nil checking during group role inspection
- more robust handling around failed SSDP task spawning
- Add a missing nil check
- Send SSDP task failure logs to hub-core, since those are
critical/irrecoverable.
- Input checking before extracing MAC from serial
- Crashes are showing that we're getting discovery info that is lacking
expected structure, and causing crashes.
- Log instead of crash on invalid key for `CaseInsensitiveKeyTable`s.
- Add checks around the security API for very old Lua Libs.
- Missed some locations where we should guard the oauth flow.
0.57 FW has an extra byte as the first byte of zdo message body payloads and is missing the last byte of the body of the payload. This adds a mitigation in the ZdoMessageBody deserialization code which overrides the Lua library function that corrects the off by 1 error and inserts a default last byte of 0x01 for every Zdo message payload.
…x-on-bad-REST-response
…id-zdo-msgs Mitigate deserialization errors due to hub 0.57 FW bug
There were a few places missing proper input validation that were leading to nil indexing crashes when using chained lookups. Out of an abundance of caution, we have tightened up input validation on all paths, even those that aren't part of the identified chained queries causing issues in some situations.
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 67 files 443 suites 0s ⏱️ Results for commit 7c43811. ♻️ This comment has been updated with latest results. |
|
matter-lock_coverage.xml
zigbee-button_coverage.xml
zigbee-motion-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7c43811 |
This reverts commit 8dbfeaa.
…x-crash-in-chained-state-queries
Revert "add zigbee-bed shus mattress device"
|
Channel deleted. |
greens
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests