Skip to content

Update judgement to use modular profile for thermostat #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Huangxiangjie
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Update judgement to use modular profile for thermostat

Summary of Completed Tests

Tested with real device

Copy link

github-actions bot commented Jul 7, 2025

Copy link

github-actions bot commented Jul 7, 2025

Test Results

   67 files    443 suites   0s ⏱️
2 260 tests 2 259 ✅ 0 💤 1 ❌
3 842 runs  3 841 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 96c2001.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 7, 2025

File Coverage
All files 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 88%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 96c2001

@hcarter-775
Copy link
Contributor

hcarter-775 commented Jul 7, 2025

luacheck shows we a couple changes are needed but lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants