Skip to content

[Optimizer] Feature #2766 Add ability to apply optimizer to all categories except some #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Jul 8, 2025

No description provided.

@rbayet rbayet force-pushed the 2766-elasticsuite-optimizer-apply-to-categories-except-some-2.10-feature branch 2 times, most recently from a69fb51 to 7fc71fa Compare July 9, 2025 06:33
@rbayet
Copy link
Collaborator Author

rbayet commented Jul 9, 2025

Replaces #3343

@rbayet rbayet marked this pull request as ready for review July 10, 2025 07:06
@rbayet rbayet added the safe to test PR can be tested label Jul 10, 2025
@rbayet rbayet force-pushed the 2766-elasticsuite-optimizer-apply-to-categories-except-some-2.10-feature branch from ee5a7f9 to d67cd80 Compare July 10, 2025 07:37
@rbayet rbayet requested a review from romainruaud July 10, 2025 07:52
@rbayet
Copy link
Collaborator Author

rbayet commented Jul 10, 2025

~~ Additional thing to check (comment issued from #3343) ~~

Functional conflicts with smile/module-elasticsuite-global-optimizer (Premium) to be resolved.

Done.

@rbayet rbayet force-pushed the 2766-elasticsuite-optimizer-apply-to-categories-except-some-2.10-feature branch from d67cd80 to 65b3d0f Compare July 11, 2025 17:39
$appliedToAllCategoriesButSome = ((int) ($data['catalog_view_container']['apply_to'] ?? 0) === 2)
|| ((int) ($origData['catalog_view_container']['apply_to'] ?? 0) === 2);

if ($isAppliedToAllCategories || $wasAppliedToAllCategories || $appliedToAllCategoriesButSome) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romainruaud That's the logical thing to do BUT there is something fishy in 2.4.5 (and maybe above) + Luma where the cat_c tag is actually not part of the (FPC) cache tags for a category page.
So in effect, cache does not seem to be really purged.

@rbayet rbayet merged commit e25f367 into 2.10.x Jul 11, 2025
23 checks passed
@rbayet rbayet deleted the 2766-elasticsuite-optimizer-apply-to-categories-except-some-2.10-feature branch July 11, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test PR can be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants