Send mail refactor #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: django_mailer/__init__.py
| @@ -26,8 +29,7 @@ def send_mail(subject, message, from_email, recipient_list, | |||
| arguments are not used. | |||
|
|
|||
| """ | |||
| from django.core.mail import EmailMessage | |||
| from django.utils.encoding import force_unicode | |||
There was a problem hiding this comment.
(the imports are kept locally because setup.py imports the package to get the version number)
|
|
||
| encoded_message = models.TextField() | ||
| message = models.TextField() | ||
| html_message = models.TextField(blank=True) |
There was a problem hiding this comment.
Two things here...
Firstly, if we're changing the schema then we should probably use south.
Secondly, I'm not sure I like having html_message as a field. It seems like it'd be a better fit to have a MessageAlternative class and actually store it "properly"
mjtorn
pushed a commit
to mjtorn/django-mailer-2
that referenced
this pull request
Nov 17, 2014
- added a cron mode to the management commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
I made a new branch from your fork and applied my changes here. Take a look at it when you have time.
Thanks,
Selwin