-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env var SMING_TOOLCHAINS to allow easier change of toolchains ins… #2894
Add env var SMING_TOOLCHAINS to allow easier change of toolchains ins… #2894
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced that adding another configuration variable is an improvement, as it adds an additional layer of complexity. Did you follow any of the discussion in #2887 (specifically #2887 (comment)) ?
61ba78b
to
30548f4
Compare
The end user does not need to know or change anything. Only those that would love to have the toolchains installed in a folder other than /opt should set the variable before the installations and persist it. But the latter type of users should already be skilled enough to set and persist an env variable. But first I will need to check why the CI tests on Ubuntu are failing :) |
The latest commit in this PR clarified the need to set only one mandatory env var Only if the user wants to install the toolchains in a location other then /opt then she/he can set:
@mikee47 the changes in the scripts are, IMHO, subtle and neither increase the complexity of the code nor put extra burden to the end user. I hope the latest documentation change is making this PR a bit easier to understand. |
@slaff I'm fine with the change, as you say it's optional and has utility. In #2887, @berhoel raised the issue of making The Esp8266 and Rp2040 SDKs are both added as submodules to Sming. These are 11MiB and 13MiB, respectively. The IDF is about 1.5GiB (!). Note that whilst optimising CI build times I added the So the IDF is only lumped in with the toolchains because of its size. In addition, syncing all its submodules takes a long time so for these reasons it's just not practical to have that pulled in as a submodule. Whilst |
Just the toolchains.
I agree with you.
Absolutely. I double that too.
@mikee47 shall I merge the PR as is or you would like to see additional documentation changes? I mean we have documented the best practices, our installation scripts and tutorials adhere to these practices and every new user will start working with them. If there are advanced users that would like another directory for the toolchain(s) of choice then it is their own responsibility. |
@slaff This PR is fine as-is, thanks. |
…tall path.