Use core instead of std when possible #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate isn’t no_std yet, but core::fmt provides the exact same features as std::fmt, so let’s use it already. I’ve also standardized on using a single use, and then prefixing all of Display, Debug, Formatter and Result with fmt::.
We were previously importing many things from std even though they are available in core, this will eventually help no_std support.
When using std, rustix will just reexport the former, but when using no_std it will reimplement them.
linkmauve
force-pushed
the
more-core
branch
2 times, most recently
from
b194e3b to
dbe96f4
Compare
This still requires translation in the main drm crate.
It was only missing importing Vec from alloc at this point, everything else builds in no_std!
This will pave the way for a no_std future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously importing many things from
stdeven though they are available incore, this will eventually helpno_stdsupport.