WIP Configurable maximum buffer size #855
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the behavior of `libwayland-client`, we should default to unbounded buffers; while servers should only use bounded buffers. I'm not sure why using `roundtrip()` gets `WouldBlock` with `client_system,server_system`, but not with just `client_system`...
Matches behavior of `libwayland` and the `sys` backend.
This is necessary to increase on higher-end systems (high polling rate hardware/high refresh-rate) to avoid crashing some apps that cannot keep up with the event loop momentarily
fix buffer size set WIP
Member
Author
|
Hm, I though it was safe to rely on https://gitlab.freedesktop.org/wayland/wayland/-/commit/d074d52902633d8700ce06b484508db0f8fba02b, since the commit is dated 2021, but it was only merged in 2024. So like #735, we probably want to use elinorbgr/dlib#22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test and
rsbackend implementation for the function added in #815, based on top of #851.I still want to add bindings (and
rsimpls) corresponding towl_display_set_max_buffer_sizeandwl_client_set_max_buffer_size, but that shouldn't be hard. The main thing is adding support to thersbackend, and verifying consistent behavior.We'll need add rounding to the
rsbackend likeget_max_size_bits_for_sizein libwayland. Maybe it would be best to useNonZeroUsizein the server andOption<NonZeroUsize>in the client, to express that unbounded buffering is an option, but only in the client...