Skip to content

Fix types #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 3, 2025
Merged

Fix types #21

merged 28 commits into from
Jun 3, 2025

Conversation

PaulKGrimes
Copy link
Collaborator

Add 'raw' SMA-X type that goes to Python bytes - this is intended as a fallback/debug type.

Rearrange _TYPE_MAP etc. so that smax-python only writes standard smax-types, and reads to numpy floats and ints by default

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 75.92593% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.96%. Comparing base (8035bac) to head (2b2e505).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/smax/smax_redis_client.py 22.22% 7 Missing ⚠️
src/smax/smax_data_types.py 86.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   45.93%   46.96%   +1.02%     
==========================================
  Files           5        5              
  Lines        1502     1550      +48     
==========================================
+ Hits          690      728      +38     
- Misses        812      822      +10     
Flag Coverage Δ
unittests 46.96% <75.92%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaulKGrimes PaulKGrimes merged commit a6f621e into main Jun 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants