Skip to content

Update for the latest SMA-X specification #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2025
Merged

Update for the latest SMA-X specification #22

merged 7 commits into from
Jun 25, 2025

Conversation

PaulKGrimes
Copy link
Collaborator

This PR brings the available types for pushing to SMA-X into line with the latest strict specification. At the same time, it enables a wider range of types for pulling from SMA-X, for backwards compatibility.

New features:

  • integers or floats shared to SMA-X that overflow the requested type will automatically be promoted to the necessary width.
  • a 'maintain_type' option to smax_share has been added to retrieve the current SMA-X type from the SMA-X server, and cast the input value(s) to that type
  • a 'raw' option has been added to smax_pull, to directly return the byte sequence returned by Redis, for debugging purposes.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.60870% with 36 lines in your changes missing coverage. Please review.

Project coverage is 48.80%. Comparing base (2b2e505) to head (9a0c811).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/smax/smax_redis_client.py 81.25% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   46.96%   48.80%   +1.83%     
==========================================
  Files           5        5              
  Lines        1550     1635      +85     
==========================================
+ Hits          728      798      +70     
- Misses        822      837      +15     
Flag Coverage Δ
unittests 48.80% <82.60%> (+1.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaulKGrimes PaulKGrimes merged commit 5b7dcd5 into main Jun 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants