Fix memoryview type being returned by SmaxInt<n>.data #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy Ints have a property called .data, that returns a memory view of the object, rather than the object itself. The order of inheritance in defining SmaxInt led to the SmaxVarBase .data property being overwritten by this property. It had already been fixed in SmaxFloats, but not SmaxInts.
This patches smax_data_types.py to ensure the correct .data property is returned. A note should be added to the documentation that this overrides the numpy base .data memoryview.