Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHROOMY logos #698

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add SHROOMY logos #698

wants to merge 12 commits into from

Conversation

ShroomyProject
Copy link

Please review the following token assets:

📑 Description

✅ Checks

  • ✅ I created a new folder with the token address (all in lowercase for EVM chains, case sensitive for Solana)
  • ✅ I added the token's logo as a 32x32 PNG file, named logo-32.png
  • ✅ I added the token's logo as a 128x128 PNG file, named logo-128.png
  • ✅ I added the token's logo as a SVG file, named logo.svg
  • ✅ My SVG logo is a proper SVG and does not contain base64 encoded elements
  • ✅ My documentation/website clearly display the token address

@vercel Vercel
Copy link

vercel bot commented Feb 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tokenassets ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 9:21am

abmisx0
abmisx0 requested changes Feb 14, 2025
View reviewed changes
tokens/57073/0x0c5e2d1c98cd265c751e02f8f3293bc5764f9111/logo.svg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please vectorize the image and reduce the file size

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image should be properly vectorized and smaller now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I should've used better wording, the SVG can't have any base64 elements. The previous base64 elements need to become paths (vectorized)

The problem here is the new file doesn't contain any path tags

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, we have reuploaded it again. We are struggling to reduce the vectorized SVG size below 4mb due to the complexity of the logo design.

@abmisx0 abmisx0 added the Change Requested Change Requested label Feb 14, 2025
abmisx0
abmisx0 requested changes Feb 14, 2025
View reviewed changes
tokens/57073/0x0c5e2d1c98cd265c751e02f8f3293bc5764f9111/logo.svg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I should've used better wording, the SVG can't have any base64 elements. The previous base64 elements need to become paths (vectorized)

The problem here is the new file doesn't contain any path tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abmisx0 abmisx0 Awaiting requested review from abmisx0

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Change Requested Change Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShroomyProject @abmisx0