-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating tables in the disney usecase #14
base: master
Are you sure you want to change the base?
Conversation
Fixed table takes all dimensions from parameters and table from edges only uses the third dimension
It was dependent on the order of points, now it is not
constructing from edges
Now there is no need to supply |
Conflicts: launch/tub_feasibility_check.launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be merged to master, works in the disney use case together with branch disney_edge_grasp_integration of ec_grasp_planner.
Run together with edge_grasp_check_support (soma_utils) vision (master_disney) and temp_edges (tub_feasibilty_check)
ocado use case should not be affected, in case it is, we can roll back to the version tagged with ms5
However, I would not merge it before the review-meeting in May
This pull request implements creating:
in a
/check_kinematics_tabletop
service call.The parameter
table_pose
was renamed totable_surface_pose
, as it is not the centroid of the table, but the centroid of the table surface. Additionally, parameterstable_from_edges
andedge_frames
were introduced. From the service call definition:The
tub_feasibility_check
node now reads the parameter/feasibility_check/table_dimensions
, which is a list of three dimension of the box: width, length and height (X, Y and Z dimensions).Note that the service call now expects the
table_surface_pose
andedge_frames
frames such that the Z axis points downwards. Examples with the correct frames areexamples/disney/surface_grasp_reference.sh
andexamples/tabletop_surface_grasp_sampling_orientation.sh
.I have verified that the examples using WAM and IFCO, WAM and tabletop, Prob2 and tabletop work.