Skip to content

Conversation

@graydonhope
Copy link

Fixes the issue where socket ci would exit with code 0 even when
blocking alerts were found.

This is the expected behaviour based on our docs: https://docs.socket.dev/docs/socket-ci#non-zero-exit-code

@graydonhope graydonhope force-pushed the unhealthy-report-exit-code branch 2 times, most recently from e858d15 to 9e98037 Compare December 19, 2025 03:34
jdalton
jdalton previously approved these changes Dec 19, 2025
@jdalton jdalton changed the base branch from main to v1.x December 19, 2025 16:08
@jdalton jdalton changed the base branch from v1.x to main December 19, 2025 16:08
@jdalton jdalton dismissed their stale review December 19, 2025 16:09

missed the wrong branch

Copy link
Contributor

@jdalton jdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graydonhope Please implement this against the v1.x branch.

@graydonhope graydonhope changed the base branch from main to v1.x December 19, 2025 18:13
@graydonhope graydonhope force-pushed the unhealthy-report-exit-code branch from 9e98037 to c4bcc5c Compare December 19, 2025 18:20
@graydonhope graydonhope requested a review from jdalton December 19, 2025 18:28
@jdalton jdalton merged commit 95aa4fc into v1.x Dec 19, 2025
9 checks passed
@jdalton jdalton deleted the unhealthy-report-exit-code branch December 19, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants