Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles for DeltaMaker 3D printers #7712

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

DeltaMaker
Copy link
Contributor

Description

This pull request adds support for DeltaMaker 3D printers, with profiles for the DeltaMaker 2, DeltaMaker 2T, and DeltaMaker 2XT.

These profiles are improved versions of the original DeltaMaker profiles that are distributed with Simplify3D.

Screenshots/Recordings/Graphs

printer-selection

Tests

These profiles have been tested on DeltaMakers running Klipper firmware, and on legacy printers running Marlin.

@SoftFever
Copy link
Owner

Hi @DeltaMaker
Thank for submitting the profiles.
There are some errors in the profiles, can you take a look at these errors?
In case you want to validate your profiles locally, you can ref to this guide: https://github.com/SoftFever/Orca_tools/releases/tag/1

@christiancoleman
Copy link
Contributor

christiancoleman commented Jan 12, 2025

Thanks for the help @SoftFever. I've made a couple changes to two files, but I don't have permissions yet to make changes to this PR.
fdm_machine_common.json
fdm_process_common.json
After these changes I get a Validation completed successfully message, but I was curious about the process at large. I see some of the profile names seem to be hard-coded in CreatePresetsDialog.cpp and I was curious if changes need to be made there too.

Copy link
Contributor

@christiancoleman christiancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to get a successful validation using these changes. @SoftFever let me know if there is anything else I should look into.

…ss_common.json to validate successfully using the Orca profile validator
@christiancoleman
Copy link
Contributor

Had to make a force change to remove the fact that the commit had come over as an old company git account (wrong author) that I still had in my shell. Cleaned up my shell and this commit. Let me know if you have any questions.

@SoftFever
Copy link
Owner

@DeltaMaker
Please kindly review the errors again.

Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Noisyfox Noisyfox merged commit 02f5bc0 into SoftFever:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants