You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Added dark mode support for dialog
• Replaced wxSpinCtrl with SpinInput to match UI
• Added side texts to SpinInput's
• Used miliseconds on total ramming time to prevent usage of SpinInput with double values
• Added scaling support for buttons and tick lines
• Added cursor change while hovering and dragging buttons
• Softened colors to fix raw color palette. it looks a bit modern now
• Used orca color on buttons
• Used orange color on "NO RAMMING AT ALL" text because its warning
• Fixed alignment problems on graph values
• Used "0" on time value to match look with "0" value used on y axis (volumetric flow). previously "0.0" used on time that looks like it didnt aligned properly
• Fixed many minor issues
• updates dialog buttons
Spin Input changes
• Added an optional step control
COMPARISON
Before-After - Light theme
Before-After - Dark theme
Before-After - %200 scaling - Buttons and tick lines are very tiny
Nice work!
I know it's not the scope of the PR but I thought it would be useful to suggest :)
Would you consider expanding the ranges of the configuration to also work with prusa machines? (Not necessarily on this PR)
Basically mk4 and mmu3 requires a very high ramming value which is not possible on orca (the way I overcome this is by editing the config file manually without touching the UI).
More context: #9083
No pressure in any case, just an idea!
Nice work! I know it's not the scope of the PR but I thought it would be useful to suggest :) Would you consider expanding the ranges of the configuration to also work with prusa machines? (Not necessarily on this PR) Basically mk4 and mmu3 requires a very high ramming value which is not possible on orca (the way I overcome this is by editing the config file manually without touching the UI).
More context: #9083 No pressure in any case, just an idea!
Two thoughs:
Just simply increase the up limit to a larger number
Automatically adjust the up limit based on current value. For example, the up limit is set to 1.5x the max value of current settings
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on windows 11
CHANGES
• Added dark mode support for dialog
• Replaced wxSpinCtrl with SpinInput to match UI
• Added side texts to SpinInput's
• Used miliseconds on total ramming time to prevent usage of SpinInput with double values
• Added scaling support for buttons and tick lines
• Added cursor change while hovering and dragging buttons
• Softened colors to fix raw color palette. it looks a bit modern now
• Used orca color on buttons
• Used orange color on "NO RAMMING AT ALL" text because its warning
• Fixed alignment problems on graph values
• Used "0" on time value to match look with "0" value used on y axis (volumetric flow). previously "0.0" used on time that looks like it didnt aligned properly
• Fixed many minor issues
• updates dialog buttons
Spin Input changes
• Added an optional step control
COMPARISON
Before-After - Light theme
Before-After - Dark theme
Before-After - %200 scaling - Buttons and tick lines are very tiny
Preview of Cursor (PLAY TO PREVIEW)
