Skip to content

DialogButtons fixes and apply to more windows #9809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented Jun 5, 2025

KNOWN ISSUE

• Minor: Hover effects not working properly for first button if its loaded from cache and not refreshed
----ex: Open create presets dialog > Choose printer > Press Create > Press Return > hover effect not works for Create > Press Create again > Hover effects not working for Return button
----No automized solution yet

FIXES

• buttons doesnt get focus. switched to wxPanel instead wxWindow
• Primary button stealing focus from inputs / combo boxes. limited SetFocus function, now its focuses only if there is no focus. This will also fix cant write number / text to input boxes on some dialogs
• No left gap on small windows
• Back button translation on create printer / filament dialog. Problem with this one "Back" used as side of object on translations. added GetRETURN() for quick access and fixed proper case usage in #9831
• First button not getting hover effects. Used ->Raise() to ensure every button has correct Z-order

CHANGES

• Switched to wxPanel instead wxWindow. wxPanel also supports keyboard shortcuts when they defined in class. its not required to bind events on parent

COMPARISON

SINGLE CHOOSE DIALOG
Before-After
Screenshot-20250605202952
Screenshot-20250605203704

FLUSHING VOLUMES DIALOG
Before-After
Screenshot-20250605201932
Screenshot-20250605201920

STEP FILE IMPORT DIALOG
Before-After
Screenshot-20250605195955
Screenshot-20250605200836

PLATE NAME DIALOG
Before-After
Screenshot-20250605214917
Screenshot-20250605214941

PLATE SETTINGS DIALOG
Before-After
Screenshot-20250605215001
Screenshot-20250605222659

DROP 3MF DIALOG
Before-After
Screenshot-20250606201557
Screenshot-20250606201534

COMPARE PRESETS DIALOG
Before-After
Screenshot-20250606204917
Screenshot-20250606204855

SAVE PRESET DIALOG
Before-After
Screenshot-20250608142938
Screenshot-20250608142931

@yw4z yw4z marked this pull request as ready for review June 8, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants