-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing minting capabilities of Short Chat view #18
Conversation
Marking this as a major change (in semver) to this package, as the change is not backward-compatible. |
This is dependent on the changes in SolidOS/chat-pane#18, so do not merge until package.json reflects this update. Partial fix for SolidOS/chat-pane#16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer it if you just removed the old code (though preserve the comment on why you can't mint a new Short Chat) - it can always be retrieved from Git anyway. Leaving it in makes it uncertain for future developers whether the code is still needed or not, and makes genuine comments and code harder to parse (for the human).
@Vinnl Have implemented your requested change ^_^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we need to leave the code in because it used by the meetulator.
We also may use minting of short chats as threads within a long chat, like threads in Slack.
We need to instead have separate filter for minting as for viewing, it seems ... creationAudience or something
@timbl and I had a talk outside of GH, and concluded that we will add Power User to the list of audience for Short Chat view, which will limit the creation of related resources to Power Users. |
@timbl I've done the changes we've talked about, please review when you have time. |
As part of #17
Partial fix for #16