SONARPY-2548: Create rule S7470: PySpark's \"RDD.groupByKey\", when used in conjuction with \"RDD.mapValues\" with a commutative and associative operation, should be replaced by \"RDD.reduceByKey\" #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joke1196
changed the title
joke1196
force-pushed
the
rule/add-RSPEC-S7470
branch
3 times, most recently
from
0339673 to
c675ef1
Compare
thomas-serre-sonarsource
approved these changes
Apr 8, 2025
rules/S7470/python/rule.adoc
Outdated
Comment on lines
8
to
9
| When performing aggregations, data is usually shuffled between partitions of course, | ||
| this shuffling and its associated cost are needed to compute the result correctly. |
There was a problem hiding this comment.
Suggested change
| When performing aggregations, data is usually shuffled between partitions of course, | |
| this shuffling and its associated cost are needed to compute the result correctly. | |
| When performing aggregations, data is usually shuffled between partitions. | |
| This shuffling is needed to compute the result correctly. It has an associated cost that can impact performance. |
…ion with \"RDD.mapValues\" with a commutative and associative operation, should be replaced by \"RDD.reduceByKey\"
joke1196
force-pushed
the
rule/add-RSPEC-S7470
branch
from
48b2e70 to
8a5a51b
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: