Create rule S7946: Logging statements should use lazy evaluation to avoid performance overhead #5551
Conversation
joke1196
changed the title
|
|
rules/S7946/python/rule.adoc
Outdated
| return template.format(**kwargs) | ||
|
|
||
| # Easy to forget the formatter | ||
| logging.info("User {action}: {amount:.2f} {item}") # Noncompliant |
There was a problem hiding this comment.
Is this meant to be a f-string or template string?
There was a problem hiding this comment.
I think it would make sense to be either of them. But this whole example is really bad I will rewrite it.
There was a problem hiding this comment.
Thinking about I am not sure how much we could detect if it is a t-string that is passed to a function and then used in a logging.xxxx method.
joke1196
changed the title
|
I have rewrote the rule to make more sense sadly this rule does not apply to Python 3.14 anymore. |
|
|
2 participants
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: