BUILD-4009 Sign with DigiCert KeyLocker #8231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrzn
force-pushed
the
BUILD-4009
branch
2 times, most recently
from
452196a
to
d8906f9
Compare
julien-carsique-sonarsource
force-pushed
the
BUILD-4009
branch
2 times, most recently
from
d623eb5
to
26d30c5
Compare
Comment on lines
+108
to
+111
| # env: | ||
| # SIGNTOOL_PATH: 'C:\\Program Files (x86)\\Windows Kits\\10\\bin\\10.0.17763.0\\x64\\signtool.exe' | ||
| # PFX_PASSWORD: $(pfxPassword2021-2023) | ||
| # PFX_PATH: $(pfx.secureFilePath) |
There was a problem hiding this comment.
We have to be careful since we were signing both the generated assemblies and the Nuget packages, and we would like to preserve that behavior.
julien-carsique-sonarsource
force-pushed
the
BUILD-4009
branch
2 times, most recently
from
db8a90e
to
6bd48ac
Compare
costin-zaharia-sonarsource
force-pushed
the
BUILD-4009
branch
3 times, most recently
from
3402f98
to
3b1e5a6
Compare
julien-carsique-sonarsource
force-pushed
the
BUILD-4009
branch
7 times, most recently
from
e6b6cb5
to
9ba2aa5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
@elrzn This no longer seems to be needed, as the issue is resolved. Can the PR be closed? |
|
@zsolt-kolbay-sonarsource Hey sorry for the delay. The PR is closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.