Skip to content

SCAN4NET-34 Change version to 9.0.0-rc #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2024
Merged

SCAN4NET-34 Change version to 9.0.0-rc #2170

merged 3 commits into from
Sep 3, 2024

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Aug 29, 2024 •
edited by jira bot
Loading

@terraform-techuser terraform-techuser changed the title Change version to 9.0.0-rc SCAN4NET-34 Change version to 9.0.0-rc Aug 29, 2024
@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/bump-version-rc branch 3 times, most recently from ffecb77 to 7b2a152 Compare August 29, 2024 11:43
gregory-paidis-sonarsource
gregory-paidis-sonarsource commented Aug 29, 2024
View reviewed changes
gregory-paidis-sonarsource
gregory-paidis-sonarsource commented Aug 29, 2024
View reviewed changes
gregory-paidis-sonarsource
gregory-paidis-sonarsource commented Aug 29, 2024
View reviewed changes
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of an rc release out of nowhere. We don't have the infrastructure in place to support it.

@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/bump-version-rc branch 2 times, most recently from 978451e to 2075e0f Compare September 2, 2024 13:40
martin-strecker-sonarsource
martin-strecker-sonarsource requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested scripts/version/set-version.ps1, right?

The positional argument should be fixed, otherwise LGTM.

@gregory-paidis-sonarsource
Copy link
Contributor Author

I assume you tested scripts/version/set-version.ps1, right?

Yes, I run it with and without the prereleaseSuffix flag.
This PR was made by running it with -version "9.0.0" -prereleaseSuffix "rc"

@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/bump-version-rc branch 2 times, most recently from 7d83103 to adce4b9 Compare September 3, 2024 09:06
@gregory-paidis-sonarsource
Copy link
Contributor Author

This comment is outdated, right?

I don't think so.
I updated it to also mention the prereleaseSuffix

@martin-strecker-sonarsource
Copy link
Contributor

This comment is outdated, right?

I don't think so. I updated it to also mention the prereleaseSuffix

😕 I was referring to the GitHub comment and not the code comment:
#2170 (comment)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gregory-paidis-sonarsource
Copy link
Contributor Author

I didn't see the original thread, my bad. Yes, it is outdated. Resolving it.

martin-strecker-sonarsource
martin-strecker-sonarsource approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please merge yourself.

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 6afe704 into master Sep 3, 2024
17 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/bump-version-rc branch September 3, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregory-paidis-sonarsource @martin-strecker-sonarsource