Skip to content

Remove build number from choco packages #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

@gregory-paidis-sonarsource gregory-paidis-sonarsource commented Sep 3, 2024

Choco uses SemVer1, which does not allow anything except for [0-9A-Za-z-] after the dash in -rc.
See more details here.

@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/remove-buildNumber-generate-packages branch from 54c9112 to 859b506 Compare September 3, 2024 15:46
Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 1380c62 into master Sep 4, 2024
15 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/remove-buildNumber-generate-packages branch September 4, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants