SCAN4NET-42 Multi-Language Support: Ignore XML files #2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terraform-techuser
changed the title
costin-zaharia-sonarsource
requested changes
Sep 9, 2024
gregory-paidis-sonarsource
force-pushed
the
greg/disable-xml
branch
from
66be7cd to
20fc129
Compare
|
|
||
| <dependency> | ||
| <groupId>semigroup</groupId> | ||
| <artifactId>haskell.curry.monoid</artifactId> |
There was a problem hiding this comment.
hehe
There was a problem hiding this comment.
This is a beautiful set equipped with an associative binary operation and an identity element. 🪄
gregory-paidis-sonarsource
force-pushed
the
greg/disable-xml
branch
13 times, most recently
from
e6c0023 to
c9712ca
Compare
| assertThat(TestUtils.getMeasureAsInteger(localProjectKey, "files", ORCHESTRATOR)).isEqualTo(212); | ||
| assertThat(TestUtils.getMeasureAsInteger(localProjectKey, "lines", ORCHESTRATOR)).isEqualTo(18681); | ||
| assertThat(TestUtils.getMeasureAsInteger(localProjectKey, "ncloc", ORCHESTRATOR)).isEqualTo(14028); | ||
| assertThat(TestUtils.getMeasureAsInteger(localProjectKey, "files", ORCHESTRATOR)).isEqualTo(213); |
There was a problem hiding this comment.
Nuget.config is considered xml
gregory-paidis-sonarsource
force-pushed
the
greg/disable-xml
branch
from
c9712ca to
3255ca5
Compare
|
gregory-paidis-sonarsource
requested a review
from costin-zaharia-sonarsource
Comment on lines
+326
to
+327
| // ConsoleVBNet/App.config 6 | ||
| // ConsoleCSharp/App.config 6 |
There was a problem hiding this comment.
My understanding is that we analyze these files because they are automatically included during the compilation (SDK type project)
There was a problem hiding this comment.
Just to confirm, I did one more debug locally.
Indeed, FilesToAnalyze contains the file, so it's part of the compilation:
gregory-paidis-sonarsource
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN4NET-42