SCAN4NET-44 Multi Language Suport: Ignore analysis scope properties #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a96c095.
gregory-paidis-sonarsource
force-pushed
the
greg/ignore-sources-and-tests
branch
6 times, most recently
from
c0a925b to
742fc5d
Compare
| .setProjectKey(projectName) | ||
| .setProjectName(projectName) | ||
| .setProperty("sonar.sources", "Program.cs") // user-defined sources and tests are not passed to the cli. | ||
| .setProperty("sonar.tests", "Program.cs")); // If they were passed, it results to double-indexing error. |
There was a problem hiding this comment.
I tested this locally by deleting the AnalysisScopeProcessor and it failed with double indexing :)
gregory-paidis-sonarsource
force-pushed
the
greg/ignore-sources-and-tests
branch
5 times, most recently
from
93974b8 to
d71198f
Compare
gregory-paidis-sonarsource
force-pushed
the
greg/ignore-sources-and-tests
branch
from
d71198f to
e26e1ca
Compare
gregory-paidis-sonarsource
requested a review
from costin-zaharia-sonarsource
its/src/test/java/com/sonar/it/scanner/msbuild/sonarqube/ScannerMSBuildTest.java
Outdated
Show resolved
Hide resolved
...arScanner.MSBuild.PreProcessor/AnalysisConfigProcessing/Processors/AnalysisScopeProcessor.cs
Show resolved
Hide resolved
...arScanner.MSBuild.PreProcessor/AnalysisConfigProcessing/Processors/AnalysisScopeProcessor.cs
Outdated
Show resolved
Hide resolved
|
gregory-paidis-sonarsource
deleted the
greg/ignore-sources-and-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN4NET-44