SLCORE-988 allow clients to request which c# analyser to use #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophio-japharidze-sonarsource
force-pushed
the
SLCORE-988_notify_which_csharp_analyzer_to_use
branch
5 times, most recently
from
8d7febb
to
c6807e7
Compare
sophio-japharidze-sonarsource
requested a review
from damien-urruty-sonarsource
sophio-japharidze-sonarsource
force-pushed
the
SLCORE-988_notify_which_csharp_analyzer_to_use
branch
from
2bff000
to
2857579
Compare
| * Introduce a new method `org.sonarsource.sonarlint.core.rpc.protocol.backend.analysis.AnalysisRpcService.shouldUseEnterpriseCSharpAnalyzer` to allow clients to know what kind of C# analyzer should be used for the analysis | ||
| * The method returns a boolean value indicating whether the enterprise C# analyzer should be used or not | ||
| * The method returns `true` if a binding exists for config scope AND the related connected server has the enterprise C# plugin (`csharpenterprise`) installed | ||
| * The method returns `true` if binding exists with a SonarQube version < 10.8 (i.e. SQ versions that do not include repackaged dotnet analyzer) OR SonarCloud |
There was a problem hiding this comment.
Shouldn't it be false for this 2nd sentence? Also, what about standalone mode?
There was a problem hiding this comment.
This sentence seems correct to me. For SQ versions <10.8, the analyzer used to include ALL rules, including those that are moving to the enterprise analyzer now. So in order for users not to lose those rules, we will use enterprise analyzers.
Standalone will return false. I will update the doc.
backend/core/src/main/java/org/sonarsource/sonarlint/core/sync/SynchronizationService.java
Outdated
Show resolved
Hide resolved
...va/org/sonarsource/sonarlint/core/repository/connection/AbstractConnectionConfiguration.java
Outdated
Show resolved
Hide resolved
sophio-japharidze-sonarsource
force-pushed
the
SLCORE-988_notify_which_csharp_analyzer_to_use
branch
3 times, most recently
from
93e56aa
to
a282442
Compare
sophio-japharidze-sonarsource
force-pushed
the
SLCORE-988_notify_which_csharp_analyzer_to_use
branch
from
a282442
to
0db9bab
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-988