Skip to content

Conversation

@eray-felek-sonarsource
Copy link
Contributor

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Update steamjsonrpc SLVS-2810 Update steamjsonrpc Jan 9, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Jan 9, 2026

SLVS-2810

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/update-steamjsonrpc branch from bfbb6cb to e43cbf2 Compare January 9, 2026 13:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

SonarQube reviewer guide

Important

We are currently testing different models for AI Summary.
Please give us your feedback by filling this form.

Model A:

Summary: Upgrade StreamJsonRpc dependency from v2.6.121 to v2.8.28 across all projects.

Review Focus: Verify compatibility with the newer StreamJsonRpc version, particularly the transitive dependency updates (MessagePack 2.1→2.2, Microsoft.VisualStudio.Threading 16.7→16.9, System.IO.Pipelines 4.7→5.0). Check assembly reference baselines for correct version resolution.

Start review at: src/Integration/Integration.csproj. This is the main project file introducing the dependency change, showing direct impact and transitive dependencies.

Model B:

Summary: Upgrade StreamJsonRpc dependency from version 2.6.121 to 2.8.28 across all projects and update transitive dependencies accordingly.

Review Focus: This is a significant dependency upgrade with multiple transitive dependency changes. Key areas requiring attention:

  • MessagePack upgraded from 2.1.194 to 2.2.85 with new transitive dependencies
  • Microsoft.VisualStudio.Threading upgraded from 16.7.56 to 16.9.60
  • System.IO.Pipelines upgraded from 4.7.2 to 5.0.1
  • New transitive dependency: System.Diagnostics.DiagnosticSource 5.0.1
  • Removal of NoWarn suppression in SLCore.Listeners.UnitTests.csproj suggests compatibility improvements
  • Assembly reference baselines updated reflecting new versions (2.6.0.0 → 2.8.0.0 for StreamJsonRpc, 16.7.0.0 → 16.9.0.0 for Microsoft.VisualStudio.Threading)

Start review at: src/Integration/Integration.csproj and src/SLCore/SLCore.csproj. These are the primary project files containing the direct package reference

Review in SonarQube
See all code changes, issues, and quality metrics in one place.

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit 989c58a into feature/ef/SLVS-enable-sentry Jan 9, 2026
5 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the feature/ef/update-steamjsonrpc branch January 9, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants