Skip to content

back to prev #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

back to prev #407

merged 2 commits into from
Nov 5, 2024

Conversation

shar2710
Copy link
Contributor

@shar2710 shar2710 commented Nov 5, 2024

Description

A clear and concise description of what the PR does.

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

  • Placeholder:

Changes

List the detailed changes made in this PR.

  • Added a new feature to ...
  • Refactored the ...
  • Fixed a bug in ...

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes.

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust-2024 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:38pm

Copy link

github-actions bot commented Nov 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Soujanya2004
Copy link
Owner

@shar2710 you have changes 5000 files??
please check if u have pushed node modules
review again

@shar2710
Copy link
Contributor Author

shar2710 commented Nov 5, 2024

please check now @Soujanya2004

@Soujanya2004 Soujanya2004 merged commit 38c5ef8 into Soujanya2004:main Nov 5, 2024
3 checks passed
@Soujanya2004
Copy link
Owner

@shar2710 the deployed link if not working effeciently, toggle is not working and show listing page is loading forever
so can u revert the changes u made

@Soujanya2004
Copy link
Owner

@shar2710 as soon as possible

@Suvadip-sana
Copy link
Contributor

@Soujanya2004 All the changes she made create problem. After eliminate this changes the server work fine. Is this actually tested in locally? She not even attached her test video recording.🤣

@Soujanya2004 You should check this type of things before marge.

@Suvadip-sana
Copy link
Contributor

Suvadip-sana commented Nov 5, 2024

@Soujanya2004 So all ok. I will create a PR for this.

And one think. Why this back and previous button needed? I don't remember that in which type of modern website this feature is there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants