-
Notifications
You must be signed in to change notification settings - Fork 64
Landing page routing update #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This piece of code contains the information with updated routing.
This include the route for start exploring to lisitng section
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@dev129 screen recording u have inserted is broken please check |
@Soujanya2004 , I don't know hwy its broken everytime i record but here are the screenshots , which i think are necessary this is the footer you wished: this is the listing page which users can see when they click ''start exploring'' on landing page for including what all places are avaliable , the prices are not included so that it can be done during checkout , what many booking sites like MMT, Yatri and many sites follow: This is the sign up page which comes when we click on sign up now button below the landing page If you still need anything else, let me know. |
@dev129 great job dude |
@dev129 why the listing display is changed |
@Soujanya2004 , i know i should not have , but mark my words, if i hadn't done this then you would be going back to homepage everytime you write localhost:8080/listing and the whole website navigation would be affected, it was a bug, and neede to be solved at the earliest. |
@dev129 i have a suggestion |
U see it ryt in websites where user is asked to login or signup after entering a website |
Hi @Soujanya2004
Description
A clear and concise description of what the PR does.
Related Issues
Link any related issues using the format
Fixes #issue_number
.Changes
List the detailed changes made in this PR.
Screenshots (if applicable)
Add any screenshots that help explain or visualize the changes.
bandicam.2024-11-06.10-20-18-241.mp4
Additional Context
Any additional context or information that reviewers should be aware of.
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.