Skip to content

Landing page routing update #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Landing page routing update #416

merged 3 commits into from
Nov 6, 2024

Conversation

dev129
Copy link
Contributor

@dev129 dev129 commented Nov 6, 2024

Hi @Soujanya2004

Description

A clear and concise description of what the PR does.

  • This PR does the following:
    • Updates the landing page to include actual routes for navigation.
    • Fixes any broken or placeholder links in the landing page.
    • Enhances the user interface for better navigation and usability.

Related Issues

Link any related issues using the format Fixes #issue_number.

Changes

List the detailed changes made in this PR.

  • Updated navigation routes on the landing page to link to the corresponding pages.
  • Ensured all links point to valid pages within the application.
  • Refactored the navigation code for better maintainability and clarity.
  • Improved styling for the navigation items to enhance user experience.

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes.

bandicam.2024-11-06.10-20-18-241.mp4

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on a recent review of the landing page structure to ensure navigation routes align with the current site structure.
  • Adjustments were made to match new routes added to the project since the last update.

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I am working on this issue under GSSOC.

This piece of code contains the information with updated routing.
This include the route for start exploring to lisitng section
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust-2024 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 4:53am

Copy link

github-actions bot commented Nov 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Soujanya2004
Copy link
Owner

@dev129 screen recording u have inserted is broken please check
add screenshots atleast

@dev129
Copy link
Contributor Author

dev129 commented Nov 6, 2024

@Soujanya2004 , I don't know hwy its broken everytime i record but here are the screenshots , which i think are necessary
This is the dekstop view:
image

this is the footer you wished:
image

this is the listing page which users can see when they click ''start exploring'' on landing page for including what all places are avaliable , the prices are not included so that it can be done during checkout , what many booking sites like MMT, Yatri and many sites follow:
image

This is the sign up page which comes when we click on sign up now button below the landing page
image

Mobile view:
image

image

If you still need anything else, let me know.

@Soujanya2004
Copy link
Owner

@dev129 great job dude

@Soujanya2004 Soujanya2004 merged commit 7337db9 into Soujanya2004:main Nov 6, 2024
3 checks passed
@Soujanya2004
Copy link
Owner

@dev129 why the listing display is changed
i want u to add only landing page and necessary routes for buttons
there is completely different homepage

@dev129
Copy link
Contributor Author

dev129 commented Nov 6, 2024

@Soujanya2004 , i know i should not have , but mark my words, if i hadn't done this then you would be going back to homepage everytime you write localhost:8080/listing and the whole website navigation would be affected, it was a bug, and neede to be solved at the earliest.

@Soujanya2004
Copy link
Owner

@dev129 i have a suggestion
Why don't you try to add pop up card stating 'welcome to Wanderlust...signup for better experience' and a nice bg for that just after few seconds of visiting the website
I hope u are getting what I am trying to say

@Soujanya2004
Copy link
Owner

U see it ryt in websites where user is asked to login or signup after entering a website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Problem in landing page. No route work
2 participants