-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prover Storage Manager #1133
Merged
Merged
Prover Storage Manager #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
citizen-stig
commented
Nov 14, 2023
bkolad
reviewed
Nov 14, 2023
bkolad
reviewed
Nov 14, 2023
citizen-stig
force-pushed
the
nikolai/fork_manager_for_sov_db
branch
2 times, most recently
from
November 20, 2023 16:33
2fb636c
to
92ebfaf
Compare
citizen-stig
force-pushed
the
nikolai/fork_manager_for_sov_db
branch
from
November 20, 2023 16:37
92ebfaf
to
6d7ad6f
Compare
bkolad
reviewed
Nov 23, 2023
bkolad
reviewed
Nov 23, 2023
bkolad
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HierarchicalStorageManager
trait to rollup interface, which will replaceStorageManager
after these changes are integratedsov-prover-storage-manager
, which have implmenetations forHierarchicalStorageManager
andsov-schema-db::snapshot::QueryManager
traits.std::hash::Hash
bound torollup_interface::BlockHashTrait
.DbSnapshot
to use references instead of value.Note, this change will require performance benchmark after being integrated.
Linked Issues
Testing
Unit tests have been added to new crate
Docs
Rust documentation have been updated