Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover Storage Manager #1133

Merged
merged 13 commits into from
Nov 23, 2023
Merged

Prover Storage Manager #1133

merged 13 commits into from
Nov 23, 2023

Conversation

citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented Nov 2, 2023

Description

  • Adds HierarchicalStorageManager trait to rollup interface, which will replace StorageManager after these changes are integrated
  • Adds crate sov-prover-storage-manager, which have implmenetations for HierarchicalStorageManager and sov-schema-db::snapshot::QueryManager traits.
  • Adds std::hash::Hash bound to rollup_interface::BlockHashTrait.
  • Minor interface improvement for DbSnapshot to use references instead of value.

Note, this change will require performance benchmark after being integrated.

Linked Issues

Testing

Unit tests have been added to new crate

Docs

Rust documentation have been updated

@citizen-stig citizen-stig self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1133 (d718432) into nightly (1ae8d09) will increase coverage by 0.4%.
Report is 7 commits behind head on nightly.
The diff coverage is 97.7%.

Additional details and impacted files
Files Coverage Δ
adapters/mock-da/src/types/mod.rs 80.2% <100.0%> (+7.0%) ⬆️
full-node/db/sov-db/src/schema/tables.rs 86.4% <ø> (+1.3%) ⬆️
full-node/db/sov-schema-db/src/lib.rs 92.2% <100.0%> (-0.5%) ⬇️
...sov-prover-storage-manager/src/snapshot_manager.rs 100.0% <100.0%> (ø)
rollup-interface/src/state_machine/da.rs 84.7% <ø> (ø)
adapters/avail/src/spec/hash.rs 0.0% <0.0%> (ø)
...de/sov-prover-storage-manager/src/dummy_storage.rs 93.1% <93.1%> (ø)
full-node/db/sov-schema-db/src/snapshot.rs 91.8% <46.1%> (-0.3%) ⬇️
full-node/sov-prover-storage-manager/src/lib.rs 98.3% <98.3%> (ø)

... and 25 files with indirect coverage changes

@citizen-stig citizen-stig force-pushed the nikolai/fork_manager_for_sov_db branch 2 times, most recently from 2fb636c to 92ebfaf Compare November 20, 2023 16:33
@citizen-stig citizen-stig marked this pull request as ready for review November 22, 2023 14:04
@citizen-stig citizen-stig added this pull request to the merge queue Nov 23, 2023
Merged via the queue into nightly with commit cb607bf Nov 23, 2023
16 checks passed
@citizen-stig citizen-stig deleted the nikolai/fork_manager_for_sov_db branch November 23, 2023 12:25
@citizen-stig citizen-stig linked an issue Dec 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crate for managing Storage snapshots relationship to DA forks
3 participants