-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K, V Iterator for DbSnapshot
#1177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
citizen-stig
changed the title
Integrating snapshotable storage
K, V Iterator for Nov 27, 2023
DbSnapshot
bkolad
reviewed
Nov 29, 2023
bkolad
reviewed
Nov 29, 2023
bkolad
reviewed
Nov 29, 2023
bkolad
reviewed
Nov 29, 2023
bkolad
approved these changes
Nov 29, 2023
This was
linked to
issues
Dec 13, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DbSnapshot
struct suppose to swapDB
instate_db
andnative_db
, so they can work on top of snapshots.This PR adds 2 methods to
DbSnapshot
struct:get_largest
- returns the value of the largest key in the schemaget_prev
- returns the value of the key, that is equal or lower that the givenSecondary changes
SchemaBatch
into its own fileBTreeMap
insideScemaBatch
, so keys are sorted inside single snapshotQueryManager
trait, that allows to iterate over all key value pairs in reverse order.Linked Issues
Testing
Unit and integration tests have been added.
Docs
Docs on public methods have been added.