Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use EC2 creds from our project. Clean up after use. #892

Merged
merged 14 commits into from
Mar 20, 2025
Merged

Only use EC2 creds from our project. Clean up after use. #892

merged 14 commits into from
Mar 20, 2025

Conversation

garloff
Copy link
Member

@garloff garloff commented Mar 13, 2025

When looking for existing EC2 credentials, we only accept those created for our own project.
If we need to create one, remember this and clean it up again.

@garloff
Only use EC2 creds from our project. Clean up after use.
7e46635 
When looking for existing EC2 credentials, we only accept those
created for our own project.
If we need to create one, remember this and clean it up again.

Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff added the enhancement New feature or request label Mar 13, 2025
@garloff garloff self-assigned this Mar 13, 2025
@garloff
Copy link
Member Author

garloff commented Mar 13, 2025

This should avoid issue #890.

@mbuechse mbuechse linked an issue Mar 14, 2025 that may be closed by this pull request
[BUG] mandatory-services test fails with access error on wavestack, pco1--4 #890
Closed
garloff and others added 10 commits March 19, 2025 18:35
@garloff
Install a signal handler to clean up ec2 cred.
30af575 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Revert "Install a signal handler to clean up ec2 cred."
80beff4 
This reverts commit 30af575.
Too much complexity for too little gain.
@garloff
Use finally: for credential cleanup.
4570296 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Add marker to Secret, so we can clean up.
f035cb6 
Signed-off-by: Kurt Garloff <[email protected]>
@garloff
OK, use a custom field "owner" in the blob to tag cred.
d1ac940 
Signed-off-by: Kurt Garloff <[email protected]>
@mbuechse
imports: minor cosmetic improvement
35be033 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Remove annoying FIXME
c6e57d1 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Don't quit loop before having deleted all leftover credentials
b0fa3f3 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
make slightly more Pythonic
c41ef21 
Signed-off-by: Matthias Büchse <[email protected]>
@mbuechse
Appease flake8
d9a92f8 
Signed-off-by: Matthias Büchse <[email protected]>
mbuechse
mbuechse approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have changed a few bits; the commit messages should explain what I did.

@garloff
Copy link
Member Author

garloff commented Mar 20, 2025

Thanks for your improvements!

@garloff garloff merged commit c099b98 into main Mar 20, 2025
8 checks passed
@garloff garloff deleted the feat/cleanup-ec2-cred branch March 20, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbuechse mbuechse mbuechse approved these changes

@josephineSei josephineSei Awaiting requested review from josephineSei

Assignees

@garloff garloff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] mandatory-services test fails with access error on wavestack, pco1--4
2 participants
@garloff @mbuechse