Fixed variants field type on product_Full to be an array of variants #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not just a single variant
joeward98
requested review from
S48-Mo,
gabrieldagama and
seanpertet
and removed request for
gabrieldagama
seanpertet
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Hey @S48-Mo correct me if I'm wrong but aren't these types automatically generated from the our API spec yml file and hence we would need to make Joe's change there?
Contributor
Yes @seanpertet @joeward98, those files are auto-generated from this branch in the API specs fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.