Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations support to start and publish commands #1

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

darrenbelding
Copy link
Member

What? Why?

This PR adds translation support to allow for the publishing of translatable widgets and report invalid schema feedback in a development environment.

These changes will also be requested into the bigcommerce/widget-builder repository but to continue progressing with the adoption of this new tool while we wait, our fork can be used.

Testing / Proof

...
All unit tests pass
The start command has been tested under the following conditions:

  • With a widget containing a schema_translations.json
  • With a widget that does not contain a schema_translations.json
  • With an invalid schema_translations.json and then correcting the invalid schema
    The publish command has been tested under the following conditions:
  • With a widget containing a schema_translations.json
  • With a widget that does not contain a schema_translations.json

@darrenbelding darrenbelding merged commit 4673272 into master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants