Skip to content

BED-6148 chore: remove app config perms from power users #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Jul 7, 2025

Description

Removed WriteAppConfig and ReadAppConfig from power user

Describe your changes in detail

Motivation and Context

Resolves BED-6148

Why is this change required? What problem does it solve?

How Has This Been Tested?

integration tests auto updated and passed

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Database Migrations

Checklist:

Summary by CodeRabbit

  • Chores
    • Removed the ability for Power Users to read or modify application configuration settings.

@mistahj67 mistahj67 self-assigned this Jul 7, 2025
@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Jul 7, 2025
Copy link
Contributor

coderabbitai bot commented Jul 7, 2025

Walkthrough

The changes remove the application configuration read and write permissions from the "Power User" role in both the codebase and the database migration script, ensuring that this role no longer has access to application configuration management.

Changes

File(s) Change Summary
cmd/api/src/auth/role.go Removed AppReadApplicationConfiguration and AppWriteApplicationConfiguration from RolePowerUser.
cmd/api/src/database/migration/migrations/v8.0.0.sql Migration script deletes "ReadAppConfig" and "WriteAppConfig" permissions from "Power User" role in the database.

Suggested labels

infrastructure

Poem

The Power User’s paws once roamed so free,
Tweaking configs with glee and esprit.
But now those keys are tucked away,
No more configs for them to sway.
Roles evolve, permissions shift—
Change is the codebase’s natural gift!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 324055e and 2fe4225.

📒 Files selected for processing (2)
  • cmd/api/src/auth/role.go (0 hunks)
  • cmd/api/src/database/migration/migrations/v8.0.0.sql (1 hunks)
💤 Files with no reviewable changes (1)
  • cmd/api/src/auth/role.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • cmd/api/src/database/migration/migrations/v8.0.0.sql
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build BloodHound Container Image / Build and Package Container
  • GitHub Check: run-tests
  • GitHub Check: run-analysis
  • GitHub Check: build-ui
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mistahj67 mistahj67 merged commit 9cb087a into main Jul 14, 2025
9 checks passed
@mistahj67 mistahj67 deleted the BED-6148 branch July 14, 2025 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants