Skip to content

BED-6154 - Remove Use of Deprecated Logic #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

BED-6154 - Remove Use of Deprecated Logic #1659

merged 1 commit into from
Jul 10, 2025

Conversation

zinic
Copy link
Contributor

@zinic zinic commented Jul 8, 2025 •
edited by coderabbitai bot
Loading

Description

Removes unnecessary legacy logic that is better served by consolidated paths.

Motivation and Context

Resolves BED-6154

No broken windows. Latest dawgs release cleans this up and bumping the version brings BH in line.

How Has This Been Tested?

Unit tests updated and integration tests pass.

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

Summary by CodeRabbit

  • Refactor

    • Unified and simplified path aggregation logic for graph analysis, introducing a new interface-based design and thread-safe wrapper.
    • Updated traversal handling to use a more general and consistent approach for group membership resolution.
    • Removed conditional filtering of impacting nodes, treating all nodes in a path as impacting.
    • Removed legacy concurrency-safe aggregator implementation and related tests.

  • Tests

    • Updated and removed several tests to align with the new aggregator structure and logic.

  • Chores

    • Upgraded multiple dependencies to improve stability and compatibility.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025 •
edited
Loading

Warning

Rate limit exceeded

@zinic has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4d050c6 and a95aff2.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • go.mod (5 hunks)
  • packages/go/analysis/ad/membership.go (4 hunks)
  • packages/go/analysis/impact/aggregator.go (10 hunks)
  • packages/go/analysis/impact/aggregator_test.go (2 hunks)
  • packages/go/analysis/impact/id_aggregator.go (0 hunks)
  • packages/go/analysis/impact/id_aggregrator_test.go (0 hunks)

Walkthrough

The changes refactor the group membership and impact analysis logic to use a unified traversal API based on PathSegment, update traversal query methods, and simplify impact aggregation. The aggregator is now an interface with a thread-safe wrapper, and node impact handling is streamlined. Legacy aggregator implementations and related tests are removed. Dependency versions in go.mod were also updated.

Changes

Files/Groups Change Summary
go.mod Updated multiple dependencies including github.com/specterops/dawgs from v0.1.5 to v0.2.0 and others.
packages/go/analysis/ad/membership.go Refactored to use new traversal API (PathSegment), updated query methods, and adjusted delegate signatures.
packages/go/analysis/impact/aggregator.go Refactored aggregator as an interface, added thread-safe wrapper, simplified node impact handling.
packages/go/analysis/impact/aggregator_test.go Removed a test, updated helper and test signatures, and removed some assertions.
packages/go/analysis/impact/id_aggregator.go,
id_aggregrator_test.go		 Deleted legacy path aggregator implementation and its associated unit test.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Membership
    participant Traversal
    participant Aggregator

    Client->>Membership: ResolveAllGroupMemberships()
    Membership->>Traversal: New traversal with PathSegment
    Traversal->>Membership: Traversal results (PathSegment)
    Membership->>Aggregator: AddPath/AddShortcut(PathSegment)
    Aggregator->>Membership: Cardinality(), Resolved()
    Membership-->>Client: Aggregated group memberships
Loading

Possibly related PRs

Suggested labels

api, enhancement

Suggested reviewers

  • benwaples

Poem

A hop through the code, a leap through the graph,
Traversals now unified, no more legacy chaff.
Aggregators refactored, thread-safety in tow,
Old tests and files, it’s time to let go.
With paws on the keyboard and whiskers held high,
The codebase is lighter—oh my, oh my! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zinic zinic force-pushed the BED-6154 branch 4 times, most recently from 4d050c6 to 75d2cff Compare July 8, 2025 19:53
@zinic zinic merged commit cbce89f into main Jul 10, 2025
9 checks passed
@zinic zinic deleted the BED-6154 branch July 10, 2025 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvazarkar rvazarkar rvazarkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zinic @rvazarkar