Skip to content

fix: failing unit test #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: failing unit test #1667

merged 1 commit into from
Jul 9, 2025

Conversation

urangel
Copy link
Contributor

@urangel urangel commented Jul 9, 2025

closes BED-6173

Description

Unit test is updated to match changes that were made recently.

Motivation and Context

Resolves BED-6173

unit tests are failing in main currently so this fixes the issue.

How Has This Been Tested?

tests were run locally and they all pass now

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Summary by CodeRabbit

  • Tests
    • Updated test to check for the "name" label instead of "display name" in the submenu when hovering over the "Copy" menu item.

closes BED-6173
Copy link
Contributor

coderabbitai bot commented Jul 9, 2025

Walkthrough

The test for the submenu in the context menu was updated to check for the label "name" instead of "display name" when verifying the submenu's visibility and disappearance. No other logic or control flow was modified.

Changes

File(s) Change Summary
cmd/ui/src/views/Explore/ContextMenu/ContextMenuZoneManagementEnabled.test.tsx Updated test assertions to query and expect the label "name" instead of "display name" for submenu items.

Suggested labels

bug

Suggested reviewers

  • superlinkx

Poem

A menu appears, a submenu in tow,
Once labeled "display name," now "name" steals the show.
The tests keep it tidy, assertions precise,
Rabbits approve—such changes are nice!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8dd294 and 7d5d515.

📒 Files selected for processing (1)
  • cmd/ui/src/views/Explore/ContextMenu/ContextMenuZoneManagementEnabled.test.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build BloodHound Container Image / Build and Package Container
  • GitHub Check: build-ui
  • GitHub Check: run-analysis
  • GitHub Check: run-tests
🔇 Additional comments (2)
cmd/ui/src/views/Explore/ContextMenu/ContextMenuZoneManagementEnabled.test.tsx (2)

179-180: LGTM! Test assertion updated to match UI implementation.

The test correctly verifies that the "name" option is present in the submenu when hovering over the "Copy" menu item. This change aligns the test expectation with the actual UI implementation.


192-192: LGTM! Consistent test cleanup assertion.

The test correctly verifies that the "name" option disappears when unhovering. This change is consistent with the presence assertion above and ensures the test properly validates the submenu behavior.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@urangel urangel self-assigned this Jul 9, 2025
@urangel urangel added bug Something isn't working user interface A pull request containing changes affecting the UI code. labels Jul 9, 2025
Copy link
Contributor

@StephenHinck StephenHinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get a hash bump on the BHE side

@StephenHinck StephenHinck enabled auto-merge (squash) July 9, 2025 20:54
@StephenHinck StephenHinck merged commit 298a748 into main Jul 9, 2025
10 of 11 checks passed
@StephenHinck StephenHinck deleted the BED-6173 branch July 9, 2025 20:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants