-
Notifications
You must be signed in to change notification settings - Fork 197
fix: failing unit test #1667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failing unit test #1667
Conversation
closes BED-6173
WalkthroughThe test for the submenu in the context menu was updated to check for the label "name" instead of "display name" when verifying the submenu's visibility and disappearance. No other logic or control flow was modified. Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll get a hash bump on the BHE side
closes BED-6173
Description
Unit test is updated to match changes that were made recently.
Motivation and Context
Resolves BED-6173
unit tests are failing in main currently so this fixes the issue.
How Has This Been Tested?
tests were run locally and they all pass now
Screenshots (optional):
Types of changes
Checklist:
Summary by CodeRabbit