Skip to content

Conversation

@mtwango
Copy link
Member

@mtwango mtwango commented Oct 3, 2025

Not sure about changes in threading, but it doesn't build on mac 15 image without them

@cbnolok
Copy link
Contributor

cbnolok commented Oct 3, 2025

Do you remember the compiler error?

@mtwango
Copy link
Member Author

mtwango commented Oct 3, 2025

First run:

/Users/runner/work/Source-X/Source-X/src/common/basic_threading.h:154:26: error: member reference type 'const GuardedAccess<T>' is not a pointer; did you mean to use '.'?
  154 |             : lock_(owner->pmutex_), ptr_(&owner.data_)
      |                     ~~~~~^
/Users/runner/work/Source-X/Source-X/src/common/basic_threading.h:198:26: error: member reference type 'GuardedAccess<T>' is not a pointer; did you mean to use '.'?
  198 |             : lock_(owner->pmutex_), ptr_(&owner.data_)
      |                     ~~~~~^
2 errors generated.

Second run, after changing it to owner.pmutex_

/Users/runner/work/Source-X/Source-X/src/common/basic_threading.h:154:27: error: no member named 'pmutex_' in 'GuardedAccess<T>'; did you mean 'mutex_'?
  154 |             : lock_(owner.pmutex_), ptr_(&owner.data_)
      |                           ^
/Users/runner/work/Source-X/Source-X/src/common/basic_threading.h:256:20: note: 'mutex_' declared here
  256 |     mutable Mutex  mutex_;
      |                    ^
/Users/runner/work/Source-X/Source-X/src/common/basic_threading.h:198:27: error: no member named 'pmutex_' in 'GuardedAccess<T>'; did you mean 'mutex_'?
  198 |             : lock_(owner.pmutex_), ptr_(&owner.data_)
      |                           ^
/Users/runner/work/Source-X/Source-X/src/common/basic_threading.h:256:20: note: 'mutex_' declared here
  256 |     mutable Mutex  mutex_;
      |                    ^
2 errors generated.

After changing to owner.mutex_ it worked. Even IDE gave me error about unresolved symbol pmutex_

@cbnolok cbnolok merged commit ecd546a into Sphereserver:dev Oct 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants