make code more Scala 2.13 friendly #172
Conversation
|
@timcharper I think the jdk7 build fails in travis because sbt 1.2 doesn't appear to support jdk7 - is it necessary to continue jdk7 support? |
|
@pjfanning so you are able to get the 2.7.x version of Play JSON to work fine with op-rabbit without any changes? When I add it as a dependency with the current 2.1.0 version it seems to cause my client to fail connecting. |
|
@dalmat36 I am using https://github.com/pjfanning/op-rabbit in production. One difference is that my op-rabbit jars are built with play-json 2.7.4. |
|
Thanks @pjfanning I found my issue... it was unrelated to op-rabbit. play-json 2.7.4 works fine with the current version. |
|
Any news on this? |
|
@danslapman I published a 2.13 compatible jar - https://github.com/pjfanning/op-rabbit#installation (I don't have commit/publish rights in this project) |
|
jdk7 is not necessary. Let's remove it from the config and get Travis green and we can merge / publish a new artifact |
|
@timcharper com.spingo#scoped-fixtures_2.13;2.0.0 needs to be published if we want to support a scala 2.13 build -- SpinGo/scoped-fixtures#2 |
|
Can you please rebase this against the latest master? And remove CI changes? |
|
@timcharper looks like circe 0.12 does not support scala 2.11 and older versions of circe do not support scala 2.13. |
|
@pjfanning I think it's probably ok to just drop 2.11 support right now. 2.12 has been out for a really long time and people have had ample time to upgrade. |
|
|
||
| projectRoot(appName) | ||
| } | ||
| new AirbrakeNotifier().notify(notice.newNotice()) | ||
| } catch { | ||
| case e: Throwable => log.error("Unable to send airbrake notification for error", e) | ||
| } | ||
|
|
||
| private def asJavaMap(map: Map[String, String]): java.util.Map[String, Object] = { |
There was a problem hiding this comment.
Why is this method needed? Isn't it sufficient just to call "Map().asJava" ?
There was a problem hiding this comment.
asJava was returning Map<String, String> when the Airbrake APIs require Map<String, Object> so I thought it was better to create a function to produce maps of the required type
|
I've published scope-fixtures 2.0.0 for Scala 2.13 |
Some dependencies are not yet ready with scala 2.13 jars but these code changes get a lot of the way towards supporting scala 2.13.
Relates to #171