Skip to content

Try fixing the plugin publication to the GitHub repo #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

Oleg-Melnik
Copy link
Contributor

@Oleg-Melnik Oleg-Melnik commented Oct 14, 2024

This PR attempts to fix an issue with publishing the Gradle plugin to the GitHub repository.

@Oleg-Melnik Oleg-Melnik self-assigned this Oct 14, 2024
@Oleg-Melnik Oleg-Melnik requested a review from armiol October 14, 2024 15:40
@Oleg-Melnik Oleg-Melnik marked this pull request as ready for review October 14, 2024 15:40
Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oleg-Melnik LGTM with the respect to the comment left.

@@ -112,6 +112,11 @@ gradlePlugin {
}
}

publishing.publications.withType<MavenPublication>().all {
groupId = "io.spine.chords"
artifactId = "spine-chords-gradle-plugin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review this one once again: if the prefix is added automatically, let's remove it from here.

@Oleg-Melnik Oleg-Melnik merged commit f59a737 into master Oct 14, 2024
5 checks passed
@Oleg-Melnik Oleg-Melnik deleted the fix_publishing branch October 14, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants