Add kotlin protoc built-in when Java or Kotlin are enabled in a project
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... together with Spine deps.
... together with Spine deps.
The version of ProtoData is taken from the corresponding dependency object in `buildSrc`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -70,6 +70,9 @@ public final class UuidJavaRenderer extends JavaRenderer { | |||
| */ | |||
| @Override | |||
| protected void render(SourceFileSet sources) { | |||
| if (!sources.sourceRoot.endsWith("java")) { | |||
There was a problem hiding this comment.
@armiol, this line breaks the build sayin that the sourceRoot property is private. It was indeed until I opened it.
It looks like indication that we test against the "dev" version, and not the one under the development. I've tried to force versions in the root build, but it didn't give much. I still get the "private" property error.
Let's discuss when time permits.
... until #88 is resolved.
alexander-yevsyukov
changed the title
kotlin protoc built-in when Java or Kotlin are enabled in a project
armiol
approved these changes
Oct 18, 2022
gradle-plugin/src/main/kotlin/io/spine/protodata/gradle/plugin/Plugin.kt
Outdated
Show resolved
Hide resolved
...protodata-extension/src/main/java/io/spine/protodata/test/annotation/AnnotationRenderer.java
Show resolved
Hide resolved
... for the case of opening `tests` as a project in IDEA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teached ProtoData Gradle Plugin to turn
kotlinprotocbuilt-in when Java or Kotlin enabled in a project.When working on this PR the issue of incompatibility with Android projects was discovered. We need to address it before the stable release.
Other notable changes:
Spineobject.SourceFileSetis passed toJavaPrinter#90).sourceRootandtargetRootwere opened inSourceFileSet. Still, it did not allow to use these properties in the integration tests because tests seem to use the code embedded intomc-javarather than that defined in the build file.SourceFileSetalso got propertiessizeandisEmpty. It was possible to obtain these values viacountextension ofIterable, but doing it directly is a bit more efficient.